Date: Sun, 19 May 2019 17:04:17 -0400 From: Yoshihiro Ota <ota@j.email.ne.jp> To: Konstantin Belousov <kostikbel@gmail.com> Cc: ota@j.email.ne.jp, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347968 - head/sys/kern Message-ID: <20190519170417.b05e8c43b2ccf9a6826a1d21@j.email.ne.jp> In-Reply-To: <20190519175104.GP2748@kib.kiev.ua> References: <201905190918.x4J9IAs1036579@repo.freebsd.org> <20190519115228.49fdc5c833c2abe06f894dc2@j.email.ne.jp> <20190519175104.GP2748@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Konstantin, I coundn't remount ro->rw a few days ago. This change isn't related, then. I will check/tesst it again later, then. Thanks, Hiro On Sun, 19 May 2019 20:51:04 +0300 Konstantin Belousov <kostikbel@gmail.com> wrote: > On Sun, May 19, 2019 at 11:52:28AM -0400, Yoshihiro Ota wrote: > > Hi, > > > > Does this change fix 'mount -u -rw /path' to remount read-only device with write mode? > > I moticed an issue a couple of days ago but didn't have time to conform nor report. > > I do not understand your description. If you mean does this commit has > any relevance to the issue of remounting ro->rw, it should not. It only > affects rw->ro remounts, when you have a binary executed from the mount > point. > > > > > Thanks, > > Hiro > > > > On Sun, 19 May 2019 09:18:10 +0000 (UTC) > > Konstantin Belousov <kib@FreeBSD.org> wrote: > > > > > Author: kib > > > Date: Sun May 19 09:18:09 2019 > > > New Revision: 347968 > > > URL: https://svnweb.freebsd.org/changeset/base/347968 > > > > > > Log: > > > Fix rw->ro remount when there is a text vnode mapping. > > > > > > Reported and tested by: hrs > > > Sponsored by: The FreeBSD Foundation > > > MFC after: 16 days > > > > > > Modified: > > > head/sys/kern/vfs_subr.c > > > > > > Modified: head/sys/kern/vfs_subr.c > > > ============================================================================== > > > --- head/sys/kern/vfs_subr.c Sun May 19 06:01:11 2019 (r347967) > > > +++ head/sys/kern/vfs_subr.c Sun May 19 09:18:09 2019 (r347968) > > > @@ -3146,7 +3146,7 @@ loop: > > > > > > if ((vp->v_type == VNON || > > > (error == 0 && vattr.va_nlink > 0)) && > > > - (vp->v_writecount == 0 || vp->v_type != VREG)) { > > > + (vp->v_writecount <= 0 || vp->v_type != VREG)) { > > > VOP_UNLOCK(vp, 0); > > > vdropl(vp); > > > continue; > > > _______________________________________________ > > > svn-src-all@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190519170417.b05e8c43b2ccf9a6826a1d21>