Date: Wed, 19 Jun 2013 01:51:42 +0200 From: Oliver Pinter <oliver.pntr@gmail.com> To: John Marino <dragonflybsd@marino.st> Cc: ports@freebsd.org, current@freebsd.org Subject: Re: gccmakedep fix - 20130619 Message-ID: <CAPjTQNEEX187_tmqM5vSWBS4WM1ihXcBL=P5MuG76GDwD8DU2A@mail.gmail.com> In-Reply-To: <51C0EA9C.5090502@marino.st> References: <CAPjTQNF9wW2=xwzMiWMFrodW6P37y58mZ6M7qM-ZiNKzykDNFw@mail.gmail.com> <51C0EA9C.5090502@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/19/13, John Marino <dragonflybsd@marino.st> wrote: > On 6/19/2013 01:00, Oliver Pinter wrote: >> Hi all! >> >> Attached a fix to gccmakedep. > > > So.... > 1) There's already multiple PRs on this, including one I just submitted: > http://www.freebsd.org/cgi/query-pr.cgi?pr=179571 > > 2) Your patch adds an ".endif" which is already there Hmm.. now I checked in github too: https://github.com/freebsd/freebsd-ports/blob/master/devel/gccmakedep/Makefile . Sure. Then my local git repo was broken. > > 3) Is not it better to submit via PR (GNATS) rather than a mailing list? > That's what PRs are for... Mail are faster than PR-s. > > John > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNEEX187_tmqM5vSWBS4WM1ihXcBL=P5MuG76GDwD8DU2A>