Date: Thu, 11 Jul 2013 05:45:33 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: William Grzybowski <wg@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent Message-ID: <20130711054533.GA70334@FreeBSD.org> In-Reply-To: <201307101754.r6AHshZl027414@svn.freebsd.org> References: <201307101754.r6AHshZl027414@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote: > New Revision: 322724 > URL: http://svnweb.freebsd.org/changeset/ports/322724 > > @@ -43,7 +46,7 @@ CONFIGURE_ARGS+= --disable-qt-dbus > .endif > > post-patch: > - @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp > + @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp There are two problems with this part: 1) It gratuitously changes perfectly fine commas to (also perfectly fine as it might seem) bars. Gratuitous commits should generally be avoided, as they decrease STN ratio, and most importantly, they break 'svn blame'; 2) Prior to this commit, 'svn blame' would have shown that this line was added by me in r307714, to suppress bogus warning on startup of qBittorrent. I've reported this bug to upstream [1] roughly 8 months ago, and it was subsequently fixed. If you would have carefully checked this (like you've should), you would have realized that this post-patch: gimmick should just be removed now, instead of essentially putting the bug back: // Set environment variable if (!!qputenv("QBITTORRENT", QByteArray(VERSION))) { std::cerr << "Couldn't set environment variable...\n"; } This is how the code now looks after "make patch". That said, when becoming a maintainer, it is very much advised to study how a port was maintained in the past, what had been done on it, and for what reasons. Confirming with upstream goes without saying. Thank you. ./danfe [1] https://github.com/qbittorrent/qBittorrent/issues/245
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130711054533.GA70334>