Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Nov 2018 14:02:00 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        =?utf-8?Q?T=C4=B3l?= Coosemans <tijl@FreeBSD.org>
Cc:        Koichiro Iwao <meta@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r484197 - in head/lang/duktape-lib: . files
Message-ID:  <36se-4awn-wny@FreeBSD.org>
In-Reply-To: <20181106130040.75d98989@kalimero.tijl.coosemans.org> (=?utf-8?Q?=22T=C4=B3l?= Coosemans"'s message of "Tue, 6 Nov 2018 13:00:40 %2B0100")
References:  <201811051548.wA5Fmg5G063134@repo.freebsd.org> <20181106130040.75d98989@kalimero.tijl.coosemans.org>

next in thread | previous in thread | raw e-mail | index | archive | help
T=C4=B3l Coosemans <tijl@FreeBSD.org> writes:

> On Mon, 5 Nov 2018 15:48:42 +0000 (UTC) Koichiro Iwao <meta@FreeBSD.org> =
wrote:
>
>> Author: meta
>> Date: Mon Nov  5 15:48:42 2018
>> New Revision: 484197
>> URL: https://svnweb.freebsd.org/changeset/ports/484197
>>=20
>> Log:
>>   lang/duktape-lib: Update to 2.3.0
[...]
>> - libduktape.so.$(REAL_VERSION):
>> --	gcc -shared -fPIC -Wall -Wextra -Os -Wl,-soname,libduktape.so.$(SONAM=
E_VERSION) \
>> -+	$(CC) -shared $(CFLAGS) -fPIC -Wall -Wextra -Wl,-soname,libduktape.so=
.$(SONAME_VERSION) \
>> - 		-o $@ $(DUKTAPE_SRCDIR)/duktape.c
>> +-CC =3D gcc
>> ++CC =3D cc
>
> If you add 'MAKE_ARGS=3D CC=3D"${CC}"' to the port Makefile you don't need
> this patch and it makes the port build on systems where cc doesn't exist.

Well, "as is" the port currently fails to respect both CC and CFLAGS.
Changing either can be done by user for optimization, debugging or
as a workaround.

https://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html
https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?36se-4awn-wny>