Date: Fri, 2 Jan 2015 08:22:58 +0100 From: Andre Albsmeier <andre@fbsd.ata.myota.org> To: Ed Maste <emaste@freebsd.org> Cc: Andre Albsmeier <andre@fbsd.ata.myota.org>, "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: [PATCH] Fixing panic in vt_fb_blank() if fb_size is not a multiple of fb_stride Message-ID: <20150102072258.GA65505@gate> In-Reply-To: <CAPyFy2AidG0s48LH29u_fFpu9wGiVRKYzR=h1k8xw3UBKX1mgw@mail.gmail.com> References: <20150101192219.GA46601@voyager> <CAPyFy2AidG0s48LH29u_fFpu9wGiVRKYzR=h1k8xw3UBKX1mgw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 01-Jan-2015 at 19:58:49 -0500, Ed Maste wrote:
> On 1 January 2015 at 14:22, Andre Albsmeier <andre@fbsd.ata.myota.org> wrote:
> > [Crossposting to -hackers and -x11 as this is vt and i915kms related]
> >
> > I can reliably crash an older notebook (Fujitsu E8310) with Intel
> > graphics (GM965) by loading i915kms after having booted but only
> > if vt(4) is used instead of old syscons.
> >
> > Reason for the crash is a page fault in vt_fb_blank() which is
> > in /sys/dev/vt/hw/fb/vt_fb.c:
> >
> ...
> >
> > in vt_fb_blank() we find:
> >
> > for (o = info->fb_stride; o < info->fb_size; o += info->fb_stride) {
> > info->copy(info, o, 0, info->fb_stride);
> > }
>
> Thank you for the report and investigation. This is fixed in HEAD by
> r268771 and r268796, which rework vt_fb_blank. There are a number of
I should have looked there instead of wasting 3 hours debugging that ;-).
But at least I did something against my clumsiness in debugging KLDs...
> other vt(4) changes that are not in stable/9; I will see if most/all
Right ;-) One thing is the ALT_BREAK_TO_DEBUGGER feature:
http://lists.freebsd.org/pipermail/freebsd-hackers/2014-December/046682.html
And we also need this one:
http://lists.freebsd.org/pipermail/svn-src-all/2014-December/095666.html
> of it may be feasibly merged back, or otherwise commit a change for
> this problem.
That would be great, thanks.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150102072258.GA65505>