Date: Sun, 26 Mar 2000 03:42:24 -0500 From: "C. Stephen Gunn" <csg@waterspout.com> To: Matt Dillon <dillon@FreeBSD.ORG> Cc: archie@FreeBSD.ORG, rwatson@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet if_ether.c Message-ID: <20000326034224.A3491@waterspout.com> In-Reply-To: <20000326024700.A3342@waterspout.com>; from csg@waterspout.com on Sun, Mar 26, 2000 at 02:47:00AM -0500 References: <200003231859.KAA01229@freefall.freebsd.org> <20000326024700.A3342@waterspout.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 26, 2000 at 02:47:00AM -0500, C. Stephen Gunn wrote: > While I understand this fix. I copied this check from the "recommended" > procedure for calling m_pullup inside. There are several instances of > missing parenthesis in sys/netgraph/*.c as well. What I meant to say (since I was obviously out of my mind on caffiene): I understand the patch. While fixing the arpintr() problem, I read Archie's article on DaemonNews about Netgraph, and changed my m_pullup() call to match his example there. After seeing your correction to my code, I checked quickly in sys/netgraph/*.c and noticed several other calls to m_pullup without the parenthesis you added. I felt I should bring it up. That make much more sense, and actually resembles English. - Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000326034224.A3491>