Date: Fri, 3 Nov 2017 23:04:17 -0700 From: Xin Li <delphij@delphij.net> To: Warner Losh <imp@bsdimp.com> Cc: d@delphij.net, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325378 - head/sys/dev/ipmi Message-ID: <04d2ee66-d19d-3aff-a30a-c87045fc884a@delphij.net> In-Reply-To: <CANCZdfrj%2BMUTyHOj=LKzR5RbajiuB7R_MQK40wHSCcf7vSFuTA@mail.gmail.com> References: <201711040301.vA431wdY002757@repo.freebsd.org> <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> <CANCZdfrj%2BMUTyHOj=LKzR5RbajiuB7R_MQK40wHSCcf7vSFuTA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO Content-Type: multipart/mixed; boundary="Nlf6FHllnGhXjapGNR1TRkS8idLeOiHhR"; protected-headers="v1" From: Xin Li <delphij@delphij.net> To: Warner Losh <imp@bsdimp.com> Cc: d@delphij.net, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <04d2ee66-d19d-3aff-a30a-c87045fc884a@delphij.net> Subject: Re: svn commit: r325378 - head/sys/dev/ipmi References: <201711040301.vA431wdY002757@repo.freebsd.org> <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> <CANCZdfrj+MUTyHOj=LKzR5RbajiuB7R_MQK40wHSCcf7vSFuTA@mail.gmail.com> In-Reply-To: <CANCZdfrj+MUTyHOj=LKzR5RbajiuB7R_MQK40wHSCcf7vSFuTA@mail.gmail.com> --Nlf6FHllnGhXjapGNR1TRkS8idLeOiHhR Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/3/17 22:53, Warner Losh wrote: >=20 >=20 > On Fri, Nov 3, 2017 at 11:29 PM, Xin Li <delphij@delphij.net > <mailto:delphij@delphij.net>> wrote: >=20 >=20 >=20 > On 11/3/17 20:01, Warner Losh wrote: > > Author: imp > > Date: Sat Nov=C2=A0 4 03:01:58 2017 > > New Revision: 325378 > > URL: https://svnweb.freebsd.org/changeset/base/325378 > <https://svnweb.freebsd.org/changeset/base/325378>; > > > > Log: > >=C2=A0 =C2=A0Make the startup timeout 0 seconds by default rathern= than 420s.=C2=A0 This > >=C2=A0 =C2=A0makes the default fail safe when watchdogd is disable= d (which is also > >=C2=A0 =C2=A0the default). >=20 > I'm not sure if this is good: what if watchdogd is enabled, but the= > system get stuck before watchdogd starts? >=20 >=20 > Correct. This feature has to be opt-in on top of watchdogd. If you don'= t > add-in this feature, you won't have this new protection. You have to se= t > hw.ipmi.wd_startup_countdown to activate it. >=20 > More complicated logic may be possible, but the ipmi driver has no clue= > if watchdogd is enabled, so I'm not sure I see a path forward to > automatically doing the right thing with sensible defaults. Have I > overlooked something? No you didn't. I missed the fact that hw.ipmi.wd_startup_countdown can be set in loader. Sorry for the noise. Cheers, --Nlf6FHllnGhXjapGNR1TRkS8idLeOiHhR-- --iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZ/VhkAAoJEJW2GBstM+nslVIQAJGJ21WP/KyHT3kh0sgrQtc0 D6B6aD646VK0MwzoLpk4xx6NxMoB0ninNKil8IZIm/h4seex3ZV0HPu/VEJj+7dS cTZsK8ojh2hoAsvQYW2BHYX8VeT6fI+84N8wKNIa/1IN+8EMjMvINzlgDFMHDiQE VmTnw5TaPn/KbUlP8XrmktFZ+YzzYT9U7wFcGBkriCSicGidr+aVtzyujajS3JdY i8Fu0sssS1BzFmEV1zxzQjrI0eiPuxpXL/9J1+KawFMt7Y/SZ13m4wa3p2JAMHn6 J+eE5Fa38He20RcDSPaXfFXlowyDigBSI+qFdlQSd87BQiDD9FL79aS5Wv0Hi2Y9 17L+/iiB7hI5RSl3KIJM0FmaJRq3Iel9biMrj2cjYFc3uauv0YvQeTZnRCjQ04JY HSJQRSgxSef2OCCWMLtPIDW1u4RMdUeVuHNATWwCkWxZ7gdpthLiL0RadeR7yubx /N9ahnygJ4XEmQ0Tfx1LPmLt3CwUP6tBznYmoF412AmNa44gkHD+bNtrCoPRVzxP BF/QuHigAOsXu5sPPqhrawnpyKL9mVLwdS3o+AeADCORKfoay6yuLRXM7SOIh2JH g2DYHQir3faBJ/y+ShVFDF/LiKlqxfMaaCSSRuNQVlWbpQrBEdb83M0uXF2Te7qB /3RnlYNPHhakp/0V6yjd =o/uD -----END PGP SIGNATURE----- --iv6N4gGOMnuHePPbCa1kXQxHoA61D5UIO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?04d2ee66-d19d-3aff-a30a-c87045fc884a>