Date: Thu, 27 Aug 2015 13:23:24 +0200 From: John Marino <freebsd.contact@marino.st> To: Dmitry Marakasov <amdmi3@amdmi3.ru>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395409 - head/astro/geographiclib Message-ID: <55DEF32C.5040202@marino.st> In-Reply-To: <55DEEFC2.40309@marino.st> References: <201508270944.t7R9ia0R067164@repo.freebsd.org> <20150827100953.GA78107@FreeBSD.org> <20150827105912.GF41937@hades.panopticon> <55DEEFC2.40309@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/27/2015 1:08 PM, John Marino wrote: > On 8/27/2015 12:59 PM, Dmitry Marakasov wrote: >> * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: >> >>>> New Revision: 395409 >>>> URL: https://svnweb.freebsd.org/changeset/ports/395409 >>>> >>>> [...] >>>> GRAVITY_NAMES:= egm84 egm96 egm2008 wgs84 grs80 >>>> -MAGNETIC_NAMES:= wmm2010 wmm2015 igrf11 igrf12 emm2010 >>>> +MAGNETIC_NAMES:= wmm2010 wmm2015 igrf11 igrf12 emm2010 emm2015 >>> >>> Why := (assignment with immediate expansion) is used here, esp. for constant >>> values? >> >> Ask maintainer. >> > > I thought it had been clearly established (by mat@ IIRC) that this kind > of response is not acceptable as a reason for ports mistakes. The > committer is supposed to review the port he or she is committing and > catch errors. The maintainers simply don't have the same level of > experience as committers do. > > Probably answer: > Maintainer didn't know any better and the mistake has been missed every > time the port is maintained. > > I'm fine with "I missed it" but not so much with blaming the maintainer > or assuming the maintainer did it intentionally for a good technical reason. > FYI, I committed the first version and *I* missed it then. In my defense, I modified many, many things in that port. It needed a lot of help but I didn't see that one. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55DEF32C.5040202>