Date: Sat, 23 Apr 2011 13:07:35 +0000 (UTC) From: "Simon L. Nielsen" <simon@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r220968 - head/contrib/traceroute Message-ID: <201104231307.p3ND7Z3Q090498@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: simon Date: Sat Apr 23 13:07:35 2011 New Revision: 220968 URL: http://svn.freebsd.org/changeset/base/220968 Log: Check return code of setuid() in traceroute. While it will not fail in normal circumstances, better safe than sorry. Reported by: LLVM's clang static analyzer MFC after: 3 days Modified: head/contrib/traceroute/traceroute.c Modified: head/contrib/traceroute/traceroute.c ============================================================================== --- head/contrib/traceroute/traceroute.c Sat Apr 23 11:22:48 2011 (r220967) +++ head/contrib/traceroute/traceroute.c Sat Apr 23 13:07:35 2011 (r220968) @@ -509,7 +509,10 @@ main(int argc, char **argv) sockerrno = errno; } - setuid(getuid()); + if (setuid(getuid()) != 0) { + perror("setuid()"); + exit(1); + } #ifdef IPCTL_DEFTTL {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104231307.p3ND7Z3Q090498>