Date: Thu, 24 Mar 2011 14:22:28 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Marius Strobl <marius@alchemy.franken.de> Cc: Roger Hammerstein <cheeky.m@live.com>, Martin Matuska <mm@FreeBSD.org>, freebsd-sparc64@FreeBSD.org Subject: Re: sparc64 hang with zfs v28 Message-ID: <20110324132228.GD8326@garage.freebsd.pl> In-Reply-To: <20110324111628.GO15528@alchemy.franken.de> References: <BAY147-w5926709E28BF613C663D48F9C90@phx.gbl> <20110310185423.GA50419@alchemy.franken.de> <20110319152838.GA8594@alchemy.franken.de> <20110321175632.GA19345@darkthrone.kvedulv.de> <20110321175933.GD2086@garage.freebsd.pl> <BAY147-w266A8BF89A940BDD569D2EF9B40@phx.gbl> <20110322191117.GH15528@alchemy.franken.de> <20110323232411.GC82490@darkthrone.kvedulv.de> <4D8B08E1.5060008@FreeBSD.org> <20110324111628.GO15528@alchemy.franken.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--bjuZg6miEcdLYP6q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 24, 2011 at 12:16:28PM +0100, Marius Strobl wrote: > On Thu, Mar 24, 2011 at 10:03:29AM +0100, Martin Matuska wrote: > > zfs_ioctl_compat_post() calls depending on the ioctl > > zfs_ioctl_compat_fix_stats() or zfs_ioctl_compat_pool_get_props() > >=20 > > Both functions unpack the "zc->zc_nvlist_dst" into "nv" at the very > > beginning and I might be missing something here (works very well on > > i386/amd64) or there might be a problem elsewhere. > >=20 > > nvlist_unpack() from libnvpair (nvpair.c) calls nvlist_xunpack(), > > issuing a nvlist_xalloc(), followerd by a nvlist_common() in > > NVS_OP_DECODE mode - that's where it dies. > > nvlist_common() deals directly with endianess. > >=20 > > sys/cddl/contrib/opensolaris/common/zfs/zfs_ioctl_compat.c > > sys/cddl/contrib/opensolaris/common/nvpair/nvpair.c > >=20 >=20 > The code in zfs_ioctl_compat.c just completely misses the copyin()/ > copyout() dance. The following patch should fix this, but is compile- > tested only so far: > http://people.freebsd.org/~marius/zfs_ioctl_compat.c.diff > Which still is to be used together with: > http://people.freebsd.org/~marius/sunddi.h.diff >=20 > I'm puzzled as to why these bugs don't cause havoc on x86 ... Because on x86 you use copyin(9)/copyout(9) if you are polite. There is nothing that enforce this. I'm happy we have sparc64 to trigger such bugs. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --bjuZg6miEcdLYP6q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk2LRZQACgkQForvXbEpPzTijACeO1O+wZKEYJXPH9VRo1ArUDeY tJ0AniE1oKuGP6NMnpaF2k8YLyh71VJ7 =/VJs -----END PGP SIGNATURE----- --bjuZg6miEcdLYP6q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110324132228.GD8326>