Date: Thu, 27 Nov 2003 14:33:31 +0000 From: Jay Cornwall <jay@evilrealms.net> To: "Daan Vreeken [PA4DAN]" <Danovitsch@Vitsch.net> Cc: freebsd-current@freebsd.org Subject: Re: Panic with ugen Message-ID: <3FC60B3B.2000403@evilrealms.net> In-Reply-To: <200311270856.44214.Danovitsch@Vitsch.net> References: <1069874342.704.18.camel@klotz.local> <1069888991.2521.7.camel@klotz.local> <3FC54095.6030209@evilrealms.net> <200311270856.44214.Danovitsch@Vitsch.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Daan Vreeken [PA4DAN] wrote: > If you have time left, could you perhaps also have a look at kern/51186? > I have filed it back in March and it's still open. (Fixes a memory corruption > bug in ugen). I'm not a committer, I'm afraid, so it's probably best to get in touch with the code maintainer. (imp@freebsd.org, if the PR is correct - he did reply at the bottom of the PR) But from a brief look at the code, I can't see anything getting past this line: if(sce->fill < sce->cur && sce->cur <= sce->fill + count) If sce->fill is less than sce->cur, then sce->cur can only be <= (sce->fill + count) if count is negative. But I haven't studied the code that closely, so maybe I'm just missing something obvious. :) -- Cheers, Jay http://www.evilrealms.net/ - Systems Administrator & Developer http://www.imperial.ac.uk/ - 3rd year CS student
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FC60B3B.2000403>