Date: Thu, 22 Apr 2021 08:48:04 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 255291] Make GNU_CONFIGURE option checking fatal Message-ID: <bug-255291-7788-OnR8PCmkh8@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-255291-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-255291-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255291 --- Comment #8 from Tobias Kortkamp <tobik@freebsd.org> --- It isn't so easy. Some of the failures (libiconv, gettext-runtime) are caused by how AC_CONFIG_SUBDIRS works in autotools: > Because the packages generally support different --with-package > and --enable-feature options, the GNU Coding Standards say they > must accept unrecognized options without halting. Even a warning > message is undesirable here, so AC_CONFIG_SUBDIRS automatically > disables the warnings. https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/ht= ml_node/Option-Checking.html Maintainers cannot really fix that and it would just look like appending --enable-option-checking=3Dyes or --disable-option-checking everywhere which I don't think is an improvement. We cannot pass --enable-option-checking=3Dfatal to ports that use AC_CONFIG_SUBDIRS. But we can check for this in SET_LATE_CONFIGURE_ARGS and only enable for ports that do not use it. And yes we should guard that with DEVELOPER because this is really finicky stuff better left to the maintainers. I fixed a couple of ports: libiconv, gettext-runtime, and the USES=3Dxorg-cat:lib ports should build now. I've pushed this to https://github.com/t6/freebsd-ports/tree/tobik/enable-option-checking An updated patch can be fetched from here: https://github.com/freebsd/freebsd-ports/compare/main...t6:tobik/enable-opt= ion-checking.patch --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255291-7788-OnR8PCmkh8>