Skip site navigation (1)Skip section navigation (2)


| raw e-mail | index | archive | help
commit 15dfc47b6adc0ba6bf91f60d05c404c7621dbc11
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-04-17 17:49:30 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-04-24 21:27:27 +0000

    heimdal: asn1: Use unsigned bitfields for named bitsets

    Import upstream 6747e1628:

      asn1: Use unsigned bitfields for named bitsets

      Signed 1-bit bitfields are undefined in C.

    This should fix the following warnings, which for unknown reasons are
    errors in CI:

      /usr/src/crypto/heimdal/lib/hx509/ca.c:1020:22: warning: implicit
truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1
[-Wsingle-bit-bitfield-constant-conversion]
       1020 |         ku.digitalSignature =3D 1;
            |                             ^ ~
      /usr/src/crypto/heimdal/lib/hx509/ca.c:1021:21: warning: implicit
truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1
[-Wsingle-bit-bitfield-constant-conversion]
       1021 |         ku.keyEncipherment =3D 1;
            |                            ^ ~
      /usr/src/crypto/heimdal/lib/hx509/ca.c:1028:17: warning: implicit
truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1
[-Wsingle-bit-bitfield-constant-conversion]
       1028 |         ku.keyCertSign =3D 1;
            |                        ^ ~
      /usr/src/crypto/heimdal/lib/hx509/ca.c:1029:13: warning: implicit
truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1
[-Wsingle-bit-bitfield-constant-conversion]
       1029 |         ku.cRLSign =3D 1;
            |                    ^ ~

    PR:             276960
    Fixes:          1b7487592987
    MFC after:      1 week

    (cherry picked from commit 219b6e442308d5353b2af5f0771ce9b887b70754)

 crypto/heimdal/lib/asn1/gen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?>