Date: Tue, 05 Jan 1999 15:32:30 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: kkennawa@physics.adelaide.edu.au Cc: simokawa@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: cvs commit: ports/graphics/giftrans Makefile ports/graphics/mpeg2codec/patches patch-aa ports/graphics/splitmpg/patches patch-aa ports/graphics/xdl/patches patch-aa Message-ID: <19990105153230K.simokawa@sat.t.u-tokyo.ac.jp> In-Reply-To: Your message of "Tue, 5 Jan 1999 16:38:05 %2B1030 (CST)" <Pine.OSF.4.05.9901051634230.21257-100000@bragg> References: <Pine.OSF.4.05.9901051634230.21257-100000@bragg>
next in thread | previous in thread | raw e-mail | index | archive | help
kkennawa> --- ports/graphics/mpeg2codec/patches/patch-aa 1996/12/09 15:37:24 1.2 kkennawa> +++ /home/ncvs/ports/graphics/mpeg2codec/patches/patch-aa 1999/01/05 kkennawa> 06:00:09 1.3 kkennawa> @@ -33,9 +33,8 @@ kkennawa> # GNU gcc kkennawa> # kkennawa> -CC = gcc kkennawa> --CFLAGS = -O2 kkennawa> +CC = cc kkennawa> -+CFLAGS = -O2 -m486 kkennawa> + CFLAGS = -O2 kkennawa> kkennawa> all: mpeg2decode mpeg2encode kkennawa> kkennawa> Erm, wouldn't it be better to just do kkennawa> CFLAGS ?= -O2 kkennawa> CFLAGS += <anything else the port needs> Yes, it should be better. There are many broken ports on alpha. For "m486" option problem, I just edit patch files directly and check whether it can be built. Because I cannot do running test for all ports, I would like to keep changes as small as possible to avoid breaking working ports. I'd like to leave these kind of fix to the maintainer or someone who can check carefully. kkennawa> like I suggested on freebsd-ports when the PR was opened? Alpha people kkennawa> presumably wouldn't have CFLAGS=-m486 defined, so this works for them as well kkennawa> as anyone else who wants to use different optimization switches than the port kkennawa> was written with. I agree with your idea. /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: finger -l simokawa@sat.t.u-tokyo.ac.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990105153230K.simokawa>