Date: Thu, 09 Aug 2012 21:55:38 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Olivier Duchateau <olivierd@FreeBSD.org> Cc: svn-ports-head@freebsd.org, rene@FreeBSD.org, svn-ports-all@freebsd.org, miwi@FreeBSD.org, ports-committers@freebsd.org Subject: Re: svn commit: r302353 - head/x11-wm/xfce4-panel Message-ID: <5024944A.9020603@FreeBSD.org> In-Reply-To: <201208091937.q79JbxJa045133@svn.freebsd.org> References: <201208091937.q79JbxJa045133@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/09/2012 12:37 PM, Olivier Duchateau wrote:
>
> +.if empty(PORT_OPTIONS:MNLS)
> + @${REINPLACE_CMD} -e 's| icons \\| icons| ; \
> + s| po||' ${WRKSRC}/Makefile.in
> +.endif
This is badly broken on several levels. Clearly it wasn't tested, which
is disappointing. But the pointy hats go to miwi and rene who clearly
did not review this carefully.
Olivier, I tested r302375 and it does what it seems like you intended to
do here. Please confirm.
Doug
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5024944A.9020603>