Date: Sat, 3 Oct 1998 11:50:01 -0700 (PDT) From: Tor.Egge@fast.no To: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/8086: "systat -iostat" coredumps when displaying too much history Message-ID: <199810031850.LAA24452@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/8086; it has been noted by GNATS. From: Tor.Egge@fast.no To: dg@smp.root.com Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/8086: "systat -iostat" coredumps when displaying too much history Date: Sat, 03 Oct 1998 20:49:13 +0200 When wrefresh() is called with a subwindow as argument, __set_subwin might be called with reversed arguments if wrefresh() decides to calls quickch(). This may cause use of negative array indexes, with a resulting segfault. Since quickch() manipulates the line structures belonging to curscr, it looks like all subwindows of curscr should be updated. Index: refresh.c =================================================================== RCS file: /home/ncvs/src/lib/libcurses/refresh.c,v retrieving revision 1.13 diff -u -r1.13 refresh.c --- refresh.c 1996/07/12 18:56:05 1.13 +++ refresh.c 1998/10/03 18:23:39 @@ -682,8 +682,8 @@ * Need to repoint any subwindow lines to the rotated * line structured. */ - for (wp = win->nextp; wp != win; wp = wp->nextp) - __set_subwin(win, wp); + for (wp = curscr->nextp; wp != curscr; wp = wp->nextp) + __set_subwin(wp->orig, wp); } } - Tor Egge To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810031850.LAA24452>