Date: Sun, 16 May 2010 12:54:22 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Randall Stewart <rrs@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr Message-ID: <AANLkTilXPPhlnYN1KbEw-4DQRVIXgqje3WrrfmzQ63Rv@mail.gmail.com> In-Reply-To: <201005161943.o4GJhnTo096839@svn.freebsd.org> References: <201005161943.o4GJhnTo096839@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 16, 2010 at 12:43, Randall Stewart <rrs@freebsd.org> wrote: > Author: rrs > Date: Sun May 16 19:43:48 2010 > New Revision: 208165 > URL: http://svn.freebsd.org/changeset/base/208165 > > Log: > =A0This pushes all of JC's patches that I have in place. I > =A0am now able to run 32 cores ok.. but I still will hang > =A0on buildworld with a NFS problem. I suspect I am missing > =A0a patch for the netlogic rge driver. > > =A0JC check and see if I am missing anything except your > =A0core-mask changes This isn't a very good commit message. Commits communicate things going forward. A follow-up E-Mail CCing JC would have been a good way to chat with him about its completeness. More importantly, though, there's just no description of the contents. This is particularly frustrating as it's also not broken up into functional chunks very well. Given the fact that there are MI changes and pan-MIPS changes here it would be nice to see a little more care taken. The changes to the MIPS MP code, for instance, I thought we had discussed and decided were sub-par and easily made less invasive. I can't comment on the RMI-specific stuff except to say that it's an unenumerated jumble of VM, networking and SMP changes.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTilXPPhlnYN1KbEw-4DQRVIXgqje3WrrfmzQ63Rv>