Date: Mon, 13 Feb 2017 15:04:39 +0300 (MSK) From: Dmitry Morozovsky <marck@rinet.ru> To: Glen Barber <gjb@freebsd.org> Cc: Cy Schubert <Cy.Schubert@komquats.com>, =?ISO-8859-15?Q?Ermal_Lu=E7i?= <eri@freebsd.org>, svn-src-head@freebsd.org, George Neville-Neil <gnn@neville-neil.com>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r313675 - in head/sys: netinet netinet6 Message-ID: <alpine.BSF.2.00.1702131504060.52731@woozle.rinet.ru> In-Reply-To: <20170212183327.GA2002@FreeBSD.org> References: <gnn@neville-neil.com> <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF@neville-neil.com> <201702121624.v1CGOQGr009733@slippy.cwsent.com> <20170212183327.GA2002@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 12 Feb 2017, Glen Barber wrote: [snip previous] > > I didn't read this when I hit send on my email. Hopefully nobody takes > > offense. I was upset and still am. > > > > I still think that the revision numbers of any backout should have been > > documented in the commit log. > > > > I absolutely agree, and was the key meaning behind my "what exactly does > this mean?" reply. The commit log, as-is, provides nothing useful to > the reader. > > > Something we could do, as is expected by re@ for commits during a freeze, > > is metees also let their mentors know of what the contents of commit log > > messages will be. I think commit log messages discussing the what, why and > > rationale are as important as the code itself. > > > > I thought this was standard practice. But if not, I would agree that > both code changes and the commit log should be both approved by the > mentor. Shouldn't we then emphacise this in the Committer's Guide? -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1702131504060.52731>