Date: Sun, 17 Feb 2013 18:10:01 GMT From: Timothy Beyer <beyert@cs.ucr.edu> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/176200: update port and fix build: graphics/ocaml-images Message-ID: <201302171810.r1HIA1BA057699@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/176200; it has been noted by GNATS. From: Timothy Beyer <beyert@cs.ucr.edu> To: Michael =?ISO-8859-15?Q?Gr=FCnewald?= <michael.grunewald@laposte.net> Cc: bug-followup@FreeBSD.org, beyert@cs.ucr.edu Subject: Re: ports/176200: update port and fix build: graphics/ocaml-images Date: Sun, 17 Feb 2013 10:09:30 -0800 At Sun, 17 Feb 2013 13:08:54 +0100, Michael Gr=FCnewald wrote: >=20 > Hi Timothy, >=20 > thank you for your patch. I submitted a similar patch for several > weeks, see ports/173453. Would you mind testing the latter and report > if you notice important differences? >=20 > This PR is a duplicate of ports/173453 and should be closed. Future > conversation on this topic should take place in ports/173453. >=20 > Thank you for your help! > Michael Hi Michael, Oops, I should have checked for incoming PRs before I submitted that patch.= I am glad to know that a fix is ready! I'm not sure if mine is better or worse, but one nice thing about my patch = is that it requires fewer patches to source files (I get rid of two patches= , change tiffread.c, and leave the remaining patches the same), so it might= be easier for you to maintain. I don't know if all image formats actually render properly in mine, as I ju= st compiled Active DVI and ran the program after installing the library, bu= t my patch certainly compiled properly with all or none of the formats enab= led. It might be worth incorporating some of the changes later, if you are inter= ested. But, as long as it works, I don't mind either way. Regards, Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302171810.r1HIA1BA057699>