Date: Mon, 23 Apr 2018 10:07:03 -0600 From: Warner Losh <imp@bsdimp.com> To: "Jonathan T. Looney" <jtl@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332860 - head/sys/kern Message-ID: <CANCZdfqP5Nig_SOHm09FNweF4NqXB2j8%2B-L3axFWEfN81h1s4A@mail.gmail.com> In-Reply-To: <CADrOrmvAxuoadBM==1EEbJc4PAPwtd-vPE4Tg-pM86CvwQnnwA@mail.gmail.com> References: <201804211705.w3LH50Dk056339@repo.freebsd.org> <CAG6CVpVAKAou%2B=9dv%2Bef8txmykR%2BMCpbmvteJua7ErhXvM7rCg@mail.gmail.com> <CADrOrmsmfjuj3_rGoVydF9ahvfuCunNyrHRs1VxKZWr=cUmLhQ@mail.gmail.com> <20180422171106.GB84833@raichu> <CADrOrmvAxuoadBM==1EEbJc4PAPwtd-vPE4Tg-pM86CvwQnnwA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 23, 2018 at 9:12 AM, Jonathan T. Looney <jtl@freebsd.org> wrote: > > If we leave the default alone, I agree we should print the assertion > message (albeit with some rate limit). > We should print the first N asserts we hit during a kernel panic core dump, then stop. I'd suggest N should be 10 or 20. For me, the only asserts that have value during a panic are the ones that prevent bad things from happening. The only bad thing that really can happen is either wedging the machine, so we don't finish the dump (watchdogs solve that) or writing to a naughty place (defined as not within the bounds of a swap partition). I'm having a hard time seeing in what actual value assertions that aren't related to either of these areas buy us. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqP5Nig_SOHm09FNweF4NqXB2j8%2B-L3axFWEfN81h1s4A>