Date: Wed, 18 Aug 2010 15:56:09 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r211460 - stable/8/sys/dev/siis Message-ID: <201008181556.o7IFu9xV073597@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Wed Aug 18 15:56:09 2010 New Revision: 211460 URL: http://svn.freebsd.org/changeset/base/211460 Log: MFC r208817: Plug memory leak to silent Coverity. Error is still not really handled. Found with: Coverity Prevent(tm) CID: 4196 Modified: stable/8/sys/dev/siis/siis.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cam/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/dev/siis/siis.c ============================================================================== --- stable/8/sys/dev/siis/siis.c Wed Aug 18 15:55:20 2010 (r211459) +++ stable/8/sys/dev/siis/siis.c Wed Aug 18 15:56:09 2010 (r211460) @@ -1338,6 +1338,7 @@ siis_issue_read_log(device_t dev) ataio = &ccb->ataio; ataio->data_ptr = malloc(512, M_SIIS, M_NOWAIT); if (ataio->data_ptr == NULL) { + xpt_free_ccb(ccb); device_printf(dev, "Unable allocate memory for READ LOG command"); return; /* XXX */ }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008181556.o7IFu9xV073597>