Date: Fri, 27 Aug 2004 22:45:05 +0200 From: Gary Jennejohn <garyj@www.jennejohn.org> To: msch@snafu.de Cc: freebsd-isdn@FreeBSD.org Subject: Re: ISDN4BSD broken... Message-ID: <200408272045.i7RKj5lC031614@peedub.jennejohn.org> In-Reply-To: Message from Matthias Schuendehuette <msch@snafu.de> of "Sat, 21 Aug 2004 19:27:36 %2B0200." <200408211927.36948.msch@snafu.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthias Schuendehuette writes:
> Hi,
>
> there's still no change with 5.3-BETA1 :-(
>
A commit was just made to -current which may have fixed this. Here's
the commit message for those who don't get the commit mails.
andre 2004-08-27 18:33:08 UTC
FreeBSD src repository
Modified files:
sys/dev/hfa fore_receive.c
sys/dev/idt idt_harp.c
sys/dev/ppbus if_plip.c
sys/i4b/driver i4b_ipr.c
sys/net if_loop.c if_ppp.c if_sl.c if_spppsubr.c
netisr.c rtsock.c
sys/netgraph/atm/atmpif ng_atmpif_harp.c
sys/netinet ip_mroute.c
sys/netinet6 ah_input.c esp_input.c
sys/netipsec ipsec_input.c xform_ipip.c
Log:
Apply error and success logic consistently to the function netisr_queue() and
its users.
netisr_queue() now returns (0) on success and ERRNO on failure. At the
moment ENXIO (netisr queue not functional) and ENOBUFS (netisr queue full)
are supported.
Previously it would return (1) on success but the return value of IF_HANDOFF()
was interpreted wrongly and (0) was actually returned on success. Due to this
schednetisr() was never called to kick the scheduling of the isr. However this
was masked by other normal packets coming through netisr_dispatch() causing the
dequeueing of waiting packets.
PR: kern/70988
Found by: MOROHOSHI Akihiko <moro@remus.dti.ne.jp>
MFC after: 3 days
---
Gary Jennejohn / garyj[at]jennejohn.org gj[at]freebsd.org gj[at]denx.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408272045.i7RKj5lC031614>