Date: Thu, 13 Dec 2007 19:18:37 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 130807 for review Message-ID: <200712131918.lBDJIboe062976@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=130807 Change 130807 by hselasky@hselasky_laptop001 on 2007/12/13 19:17:39 Only clear the PORT_ENABLE feature on the HUB if the port is enabled. Else it has been observed that some HUBs will generate another port connection change and we start going into an infinite loop. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/uhub.c#26 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/uhub.c#26 (text+ko) ==== @@ -420,8 +420,10 @@ child = NULL; } if (err == 0) { + if (sc->sc_st.port_status & UPS_PORT_ENABLED) { err = usbreq_clear_port_feature (sc->sc_udev, &usb_global_lock, portno, UHF_PORT_ENABLE); + } } if (err) { DPRINTF(sc, -1, "device problem (%s), "
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712131918.lBDJIboe062976>