Date: Sun, 23 Jun 2002 16:52:55 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <Pine.NEB.3.96L.1020623165120.4933F-100000@fledge.watson.org> In-Reply-To: <200206232048.g5NKmQN17703@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yeah, I was actually thinking about committing almost the same comment on the mbuf allocation in ip_forward(). Essentially, the mbuf is only needed in failure cases, and therefore we pessimize the success case. We should just cache a 'struct ip' in the stack frame of ip_forward() and tweak the code we call to use that, presumably. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Sun, 23 Jun 2002, Luigi Rizzo wrote: > luigi 2002/06/23 13:48:26 PDT > > Modified files: > sys/netinet ip_input.c > Log: > Move some global variables in more appropriate places. > > Add XXX comments to mark places which need to be taken care of > if we want to remove this part of the kernel from Giant. > > Add a comment on a potential performance problem with ip_forward() > > Revision Changes Path > 1.203 +28 -3 src/sys/netinet/ip_input.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020623165120.4933F-100000>