Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Jul 2004 23:46:31 +0900
From:      OGAWA Takaya <t-ogawa@triaez.kaisei.org>
To:        Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
Cc:        njl@FreeBSD.org
Subject:   Re: Panasonic acpi driver
Message-ID:  <868ydq61q0.wl.t-ogawa@triaez.kaisei.org>
In-Reply-To: <20040711.182654.59665900.nyan@jp.FreeBSD.org>
References:  <20040711.182654.59665900.nyan@jp.FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Thank you for taking care of the code, Takahashi-san.

At Sun, 11 Jul 2004 18:26:54 +0900 (JST),
Takahashi Yoshihiro wrote:
> I have written the acpi_panasonic driver which is based on ogawa's
> driver.  It only supports LCD brightness control and sound mute, but
> currently the devd(8) daemon is not required anymore.

It is not a problem if the driver emits acpi events to devd for
other key events (mixer control etc.) nevertheless.  We can let
devd(8) do them in those cases.  I once had a version which do
mixer control within the kernel via NDINIT() and VOP_IOCTL() but
it was a real mess.

> http://home.jp.freebsd.org/~nyan/patches/acpi_panasonic.diff.gz

Mostly good...
> +#define	HKEY_LCD_BRIGHTNESS_SHIFT	(5 - HKEY_LCD_BRIGHTNESS_BITS)
>                                                ^ Did you mean '8' here?
On my CF-R1N it must be 8.  The object seems to have 8bit range
but I only used higher 4bits because I just don't want to hit the
key ~255 times to turn off the LCD light.

----------
おがわ たかや
t-ogawa@triaez.kaisei.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?868ydq61q0.wl.t-ogawa>