Date: Fri, 1 Feb 2008 18:22:34 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 129920 for review Message-ID: <20080202022234.GR99258@elvis.mu.org> In-Reply-To: <200712020001.lB201XbN000811@repoman.freebsd.org> References: <200712020001.lB201XbN000811@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This change makes very little sense. If xfer->frbuffers is a bare pointer, then why add 0 to it? Just pass xfer->frbuffers or use a macro that explains what you are doing. * Hans Petter Selasky <hselasky@FreeBSD.org> [071201 16:01] wrote: > http://perforce.freebsd.org/chv.cgi?CH=129920 > > Change 129920 by hselasky@hselasky_laptop001 on 2007/12/02 00:00:47 > > > "buf_data" will be removed and replaced by "frbuffers + 0". > > Affected files ... > > .. //depot/projects/usb/src/sys/dev/usb/usb_compat_linux.c#12 edit > > Differences ... > > ==== //depot/projects/usb/src/sys/dev/usb/usb_compat_linux.c#12 (text+ko) ==== > > @@ -1286,7 +1286,7 @@ > uipd = urb->iso_frame_desc + x; > uipd->actual_length = xfer->frlengths[x]; > uipd->status = 0; > - usbd_copy_out(&(xfer->buf_data), offset, > + usbd_copy_out(xfer->frbuffers + 0, offset, > ((uint8_t *)(urb->transfer_buffer)) + uipd->offset, > uipd->actual_length); > offset += max_frame; > @@ -1354,7 +1354,7 @@ > for (x = 0; x < urb->number_of_packets; x++) { > uipd = urb->iso_frame_desc + x; > xfer->frlengths[x] = uipd->length; > - usbd_copy_in(&(xfer->buf_data), offset, > + usbd_copy_in(xfer->frbuffers + 0, offset, > ((uint8_t *)(urb->transfer_buffer)) + uipd->offset, > uipd->length); > offset += uipd->length; -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080202022234.GR99258>