Date: Mon, 9 Oct 2000 11:58:47 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Dave Cornejo <dave@dogwood.com> Cc: Doug Ambrisko <ambrisko@whistle.com>, freebsd-hardware@FreeBSD.ORG, freebsd-hackers@FreeBSD.ORG Subject: Re: WEP keys for an driver Message-ID: <20001009115847.A2570@Odin.AC.HMC.Edu> In-Reply-To: <200010091842.e99IgWd05020@white.dogwood.com>; from dave@dogwood.com on Mon, Oct 09, 2000 at 11:42:32AM -0700 References: <200010091551.IAA30329@whistle.com> <200010091842.e99IgWd05020@white.dogwood.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 09, 2000 at 11:42:32AM -0700, Dave Cornejo wrote: > Some comments on your code: > - WEP keysare variable length from 5-13 bytes, you should just check for > >=5 & <=13 (it seems odd, but I have seen networks that use the odd > sizes). Since all the windows drivers I've looked at only allow 0, 5, and 13 byte keys, I'd suggest only allowing those values. That's what wicontrol does. > I didn't provide patches to ancontrol as you did, but I find ancontrol > is getting way too nasty with its switches. Your patches look fine > to me except that I'd really like to see a better way to specify > volatile vs. persistent keys. You need to add ancontrol support or the patch is basicaly useless. I'm looking forward to some sort of working crypto support for the aironet cards. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hardware" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001009115847.A2570>