Date: Fri, 28 Mar 2008 07:53:17 +0100 (CET) From: "Remko Lodder" <remko@elvandar.org> To: "Pyun YongHyeon" <yongari@FreeBSD.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/re if_re.c Message-ID: <37960.194.74.82.3.1206687197.squirrel@galain.elvandar.org> In-Reply-To: <200803280121.m2S1LMId004496@repoman.freebsd.org> References: <200803280121.m2S1LMId004496@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, March 28, 2008 2:21 am, Pyun YongHyeon wrote: > yongari 2008-03-28 01:21:21 UTC > > FreeBSD src repository > > Modified files: > sys/dev/re if_re.c > Log: > In revision 1.70, 1.71 and 1.84 re(4) tried to workaround checksum > offload bugs by manual padding for short IP/UDP frames. Unfortunately > it seems that these workaround does not work reliably on newer PCIe > variants of RealTek chips. > > To workaround the hardware bug, always pad short frames if Tx IP > checksum offload is requested. It seems that the hardware has a > bug in IP checksum offload handling. NetBSD manually pads short > frames only when the length of IP frame is less than 28 bytes but I > chose 60 bytes to safety. Also unconditionally set IP checksum > offload bit in Tx descriptor if any TCP or UDP checksum offload is > requested. This is the same way as Linux does but it's not > mentioned in data sheet. > > Obtained from: NetBSD > Tested by: remko, danger > > Revision Changes Path > 1.112 +15 -13 src/sys/dev/re/if_re.c > Many thanks!! Great work :) -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37960.194.74.82.3.1206687197.squirrel>