Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jun 2019 11:32:19 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 238662] mpt: replace mpt_prt with mpt_lprt in mpt_cam.c
Message-ID:  <bug-238662-227@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238662

            Bug ID: 238662
           Summary: mpt: replace mpt_prt with mpt_lprt in mpt_cam.c
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: huangfq.daxian@gmail.com

Created attachment 205180
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205180&action=
=3Dedit
The patch file

Replace mpt_prt with mpt_lprt with DEBUG level to
print kernel pointers in a certain debug level.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 sys/dev/mpt/mpt_cam.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/sys/dev/mpt/mpt_cam.c b/sys/dev/mpt/mpt_cam.c
index 4fbca1d9fe2..1083e083a82 100644
--- a/sys/dev/mpt/mpt_cam.c
+++ b/sys/dev/mpt/mpt_cam.c
@@ -1249,7 +1249,8 @@ mpt_timeout(void *arg)

        MPT_LOCK_ASSERT(mpt);
        req =3D ccb->ccb_h.ccb_req_ptr;
-       mpt_prt(mpt, "request %p:%u timed out for ccb %p (req->ccb %p)\n", =
req,
+       mpt_lprt(mpt, MPT_PRT_DEBUG,
+       "request %p:%u timed out for ccb %p (req->ccb %p)\n", req,
            req->serno, ccb, req->ccb);
 /* XXX: WHAT ARE WE TRYING TO DO HERE? */
        if ((req->state & REQ_STATE_QUEUED) =3D=3D REQ_STATE_QUEUED) {
@@ -2598,7 +2599,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request=
_t
*req,
        scsi_req =3D (MSG_SCSI_IO_REQUEST *)req->req_vbuf;
        ccb =3D req->ccb;
        if (ccb =3D=3D NULL) {
-               mpt_prt(mpt, "mpt_scsi_reply_handler: req %p:%u with no ccb=
\n",
+               mpt_lprt(mpt, MPT_PRT_DEBUG,
+               "mpt_scsi_reply_handler: req %p:%u with no ccb\n",
                    req, req->serno);
                return (TRUE);
        }
@@ -2655,7 +2657,8 @@ mpt_scsi_reply_handler(struct mpt_softc *mpt, request=
_t
*req,
        if ((req->state & REQ_STATE_TIMEDOUT) =3D=3D 0) {
                TAILQ_REMOVE(&mpt->request_pending_list, req, links);
        } else {
-               mpt_prt(mpt, "completing timedout/aborted req %p:%u\n",
+               mpt_lprt(mpt, MPT_PRT_DEBUG,
+               "completing timedout/aborted req %p:%u\n",
                    req, req->serno);
                TAILQ_REMOVE(&mpt->request_timeout_list, req, links);
        }
@@ -4017,7 +4020,8 @@ mpt_recover_commands(struct mpt_softc *mpt)
                uint8_t response;
                MSG_REQUEST_HEADER *hdrp =3D req->req_vbuf;

-               mpt_prt(mpt, "attempting to abort req %p:%u function %x\n",
+               mpt_lprt(mpt, MPT_PRT_DEBUG,
+               "attempting to abort req %p:%u function %x\n",
                    req, req->serno, hdrp->Function);
                ccb =3D req->ccb;
                if (ccb =3D=3D NULL) {
@@ -4092,7 +4096,8 @@ mpt_recover_commands(struct mpt_softc *mpt)
                        mpt_reset(mpt, TRUE);
                        continue;
                }
-               mpt_prt(mpt, "abort of req %p:%u completed\n", req,
req->serno);
+               mpt_lprt(mpt, MPT_PRT_DEBUG,
+               "abort of req %p:%u completed\n", req, req->serno);
        }
 }

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238662-227>