Date: Thu, 24 Apr 2008 15:35:17 -0700 From: Nate Lawson <nate@root.org> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: freebsd-acpi@FreeBSD.org, Andriy Gapon <avg@icyb.net.ua> Subject: Re: initial value of tz_active Message-ID: <48110B25.3080609@root.org> In-Reply-To: <4D198421-0D21-4DD6-9B1B-A2A8B1EB4B63@FreeBSD.org> References: <480F8E2E.8000502@icyb.net.ua> <480F921D.3050505@root.org> <480FBA31.2050202@icyb.net.ua> <4810F8DB.3090507@icyb.net.ua> <4D198421-0D21-4DD6-9B1B-A2A8B1EB4B63@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rui Paulo wrote:
>
> On 24 Apr 2008, at 22:17, Andriy Gapon wrote:
>
>> on 24/04/2008 01:37 Andriy Gapon said the following:
>>> I agree - this is a better approach.
>>> On a technical level - maybe use TZ_ACTIVE_UNKNOWN=-2 instead of a new
>>> variable.
>>> I'll try to work on this somewhere in the middle of May.
>>
>> I've couple of spare hours this evening, so I decided to not delay this
>> small thing until after the vacation.
>> Result is attached.
>> My short testing shows that the patch does the job and doesn't introduce
>> any problems.
>> @@ -543,6 +545,22 @@ acpi_tz_monitor(void *Context)
>> newflags |= TZ_THFLAG_CRT;
>>
>> /* If the active cooling state has changed, we have to switch
>> things. */
>> + if (sc->tz_active == TZ_ACTIVE_UNKNOWN) {
>> + /* We don't know which cooling device is on or off,
>
> Please make this:
> "/*"
> " * We don't ..."
> to comply with style.
> Looks good to me.
Me too, please commit with the style fix.
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48110B25.3080609>