Date: Mon, 25 Jul 2011 17:03:05 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: shaun@FreeBSD.org Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: www/en/cgi Makefile www/share/mk web.site.mk Message-ID: <20110725.170305.1112186546386513449.hrs@allbsd.org> In-Reply-To: <20110721125514.GA57642@charon.picobyte.net> References: <201107202352.p6KNqCkN034366@repoman.freebsd.org> <20110721.123130.698363444164784046.hrs@allbsd.org> <20110721125514.GA57642@charon.picobyte.net>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Mon_Jul_25_17_03_05_2011_636)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Shaun, Shaun Amott <shaun@FreeBSD.org> wrote in <20110721125514.GA57642@charon.picobyte.net>: sh> On Thu, Jul 21, 2011 at 12:31:30PM +0900, Hiroki Sato wrote: sh> > What do you think about the attached patch? I did not notice these sh> > changes were submitted somewhere for review before the commit... sh> > sh> > -- Hiroki sh> sh> Hi Hiroki, sh> sh> The change was a temporary quick-fix to get the PR viewer working again. sh> I am not intimately familiar with the doc build system, so wasn't sure sh> about the best way to add the new subdirectories; but your way looks a sh> lot cleaner to me. sh> sh> The script itself was made available some time ago on freebsd-www, so I sh> considered it reviewed; I just didn't foresee the need for the other sh> changes. Thank you for your reply. I committed the patch just now and is checking if things go well. I do not think there is a serious problem with your commit, but next time when you have to change our www/doc build infrastructure, please submit a whole patch including that change to -doc@. As you know it is (unnecessarily) complex and breaking the build prevents www.freebsd.org from updating. I and other doc folks are willing to review it. -- Hiroki ----Security_Multipart(Mon_Jul_25_17_03_05_2011_636)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk4tIzkACgkQTyzT2CeTzy0G5gCgsBvmA0mwUc6WXNbPqc2hbxiy UfQAn186yRrinQUqP1mQ08YFRgG70ivf =LUvA -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Jul_25_17_03_05_2011_636)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110725.170305.1112186546386513449.hrs>