Date: Fri, 28 Dec 2012 14:04:03 -1000 (TAHT) From: Gerald Pfeifer <gerald@pfeifer.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/174790: Mk/bsd.port.mk: revert part of r303619, CPPFLAGS and LDFLAGS already are part of CONFIGURE_ENV Message-ID: <alpine.LNX.2.00.1212271718050.4452@tuna.site> Resent-Message-ID: <201212290010.qBT0A0rO061593@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 174790
>Category: ports
>Synopsis: Mk/bsd.port.mk: revert part of r303619, CPPFLAGS and LDFLAGS already are part of CONFIGURE_ENV
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Dec 29 00:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Gerald Pfeifer/BSD
>Release:
>Organization:
>Environment:
>Description:
As I responded on svn-ports-all@ and portmgr@ back in early
November, part of r303619 is not correct since CONFIGURE_ENV
already sets CPPFLAGS and LDFLAGS by default.
If this does not happen for readline, then there is a bug
somewhere that should be addressed right on, not by adding
this redundant statement.
Reference:
r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 lines
Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV
PR: 153625
Submitted by: gerald
>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
--- bsd.port.mk (revision 308475)
+++ bsd.port.mk (working copy)
@@ -1712,7 +1712,6 @@
LIB_DEPENDS+= readline.6:${PORTSDIR}/devel/readline
CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib -lreadline
-CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
.endif
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1212271718050.4452>