Date: Wed, 24 Aug 2011 06:59:59 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r225132 - user/adrian/if_ath_tx/sys/dev/ath Message-ID: <201108240659.p7O6xxvr037781@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Wed Aug 24 06:59:59 2011 New Revision: 225132 URL: http://svn.freebsd.org/changeset/base/225132 Log: Add a comment describing what may occur during retries. Another thing to sort out before this is merged into -HEAD. Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 06:57:29 2011 (r225131) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 06:59:59 2011 (r225132) @@ -1907,10 +1907,13 @@ _ath_getbuf_locked(struct ath_softc *sc) * be again passed through the descriptor setup/chain routines * so the link is correct. * - * XXX TODO: the source buffer is still valid; so the mbuf - * XXX will be freed when that buffer is freed! The bf callback - * XXX will be called too, etc, etc. - * XXX so the caller must handle this somehow! + * The caller must free the buffer using ath_freebuf(). + * + * XXX TODO: this call shouldn't fail as it'll cause packet loss + * XXX in the TX pathway when retries are needed. + * XXX Figure out how to keep some buffers free, or factor the + * XXX number of busy buffers into the xmit path (ath_start()) + * XXX so we don't over-commit. */ struct ath_buf * ath_buf_clone(struct ath_softc *sc, const struct ath_buf *bf)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108240659.p7O6xxvr037781>