Date: Fri, 12 Dec 2003 16:52:55 +1000 From: Peter Grehan <grehan@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: obrien@freebsd.org Subject: Re: cvs commit: src/sys/boot/powerpc/loader conf.c Message-ID: <3FD965C7.1000906@freebsd.org> In-Reply-To: <20031211194303.X10479@gamplex.bde.org> References: <200312100917.hBA9H26R081659@repoman.freebsd.org> <3FD6F0F2.4955B5B2@freebsd.org> <xzpbrqgn11y.fsf@dwp.des.no> <3FD7CD6A.8010909@freebsd.org> <20031211030704.GA53066@dragon.nuxi.com> <3FD7FD29.7050803@freebsd.org> <20031211194303.X10479@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> These changes seem to be basically correct and have correct style > except for not merging the declarations of most of the new "int ch" > variables with the declarations of the other int variables. OK, I'll sweep through and fix that. > The fix for kg_nice in proc.h is missing. Only the relatively unimportant > declaration of ki_nice in user.h is fixed. Yep, mis-edited that one out of the diff :-(. > What bugs does putting negative niceness in the (unsigned) char variable > kg_nice cause? Comparisons to NZERO don't work as expected e.g. /usr/home/grehan/freebsd/dev/src/bin/ps/print.c: In function `state': /usr/home/grehan/freebsd/dev/src/bin/ps/print.c:250: warning: comparison is always false due to limited range of data type later, Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FD965C7.1000906>