Date: Tue, 13 Aug 2002 05:14:07 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: Terry Lambert <tlambert2@mindspring.com>, David Xu <bsddiy@yahoo.com>, Julian Elischer <julian@elischer.org>, FreeBSD CURRENT <freebsd-current@FreeBSD.ORG> Subject: Re: cvs commit: src/sys/kern kern_sig.c (fwd) Message-ID: <20020813050607.R25861-100000@gamplex.bde.org> In-Reply-To: <20020812172131.GA2139@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 12 Aug 2002, Andrey A. Chernov wrote: > On Tue, Aug 13, 2002 at 03:15:02 +1000, Bruce Evans wrote: > > > > Anyway, it has one blatant style bug (not 1TBS) and no explanation of > > the bug, so it should not have been committed verbatim. See another > > reply for an analysis of the patch. > > According to commit guide, explanations are not commited, only what is > changed. For explanation (terminal group mismatch) read whole thread, > especially David's analysis. The analysis in the thread seems to be incomplete. > What another reply you mean? I just wrote one :-). Rereading earlier analysis just gave me a hint about tcsetpgrp() to the same value causes problems: it causes an unexpected SIGTTOU because a background process attemps to do something (TIOCSPGRP) that can only be done in the foreground (the background process is forced to wait until it gets to the foreground, and it doesn't help for the change to be null since the process must be in the foreground to even check for null changes). Presumably the child su is in the foreground at that point. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020813050607.R25861-100000>