Date: Sun, 10 Apr 2005 16:40:49 +0200 (MEST) From: Michiel Boland <michiel@boland.org> To: Mark Knight <markk@knigma.org> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: bin/78570: "wicontrol -i wi0 -C" outputs garbage Message-ID: <Pine.GSO.4.62.0504101639030.17395@brakkenstein.nijmegen.internl.net> In-Reply-To: <200503080132.j281WRYH001684@shrewd.pub.knigma.org> References: <200503080132.j281WRYH001684@shrewd.pub.knigma.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Since at least 5.3, wicontrol -i wi0 -C has been broken. The following patch to /usr/src/usr.sbin/wicontrol/wicontrol.c fixes things for me (on 6.0-CURRENT) --- wicontrol.c.orig Sun Oct 17 23:29:53 2004 +++ wicontrol.c Sun Apr 10 15:33:47 2005 @@ -1020,10 +1020,8 @@ wi_readcache(const char *iface) { struct wi_req wreq; - int *wi_sigitems; struct wi_sigcache *sc; - char * pt; - int i; + int i, n; if (iface == NULL) errx(1, "must specify interface name"); @@ -1034,13 +1032,11 @@ if (wi_getval(iface, &wreq) == -1) errx(1, "Cannot read signal cache"); - wi_sigitems = (int *) &wreq.wi_val; - pt = ((char *) &wreq.wi_val); - pt += sizeof(int); - sc = (struct wi_sigcache *) pt; + n = wreq.wi_len * 2 / sizeof (struct wi_sigcache); /* XXX ?? */ + sc = (struct wi_sigcache *) &wreq.wi_val; - for (i = 0; i < *wi_sigitems; i++) { - printf("[%d/%d]:", i+1, *wi_sigitems); + for (i = 0; i < n; i++) { + printf("[%d/%d]:", i+1, n); printf(" %02x:%02x:%02x:%02x:%02x:%02x,", sc->macsrc[0]&0xff, sc->macsrc[1]&0xff,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.62.0504101639030.17395>