Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Feb 2013 15:52:04 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Randall Stewart <rrs@lakerest.net>
Cc:        freebsd-net@freebsd.org, Robert Watson <rwatson@freebsd.org>, Jack Vogel <jfvogel@gmail.com>, Kip Macy <kmacy@freebsd.org>
Subject:   Re: Driver patch to look at...
Message-ID:  <201302051552.04275.jhb@freebsd.org>
In-Reply-To: <74624C61-0564-420F-9F82-0475488F857C@lakerest.net>
References:  <D3AA078A-CD19-4228-A019-BE9C985895E2@lakerest.net> <201302051411.52495.jhb@freebsd.org> <74624C61-0564-420F-9F82-0475488F857C@lakerest.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, February 05, 2013 2:30:36 pm Randall Stewart wrote:
> Ok
> 
> Here it is one last time (I hope) with the updates ;-)

One more suggestion.  I would make the check in buf_ring_putback_sc() a 
KASSERT() so that in the production case we don't pay for a branch that should 
never occur.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302051552.04275.jhb>