Date: Wed, 1 May 2019 12:40:56 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: "Tobias C. Berner" <tcberner@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r500363 - in head/sysutils: . etc_os-release Message-ID: <20190501104056.zguyzu4syrv4ms4r@atuin.in.mat.cc> In-Reply-To: <CAOshKtfcEZ7AuwkfPs56yC9oMUmmL%2Bu7JcQO3mv_5WV2fip%2BEQ@mail.gmail.com> References: <201904281922.x3SJMLo2013472@repo.freebsd.org> <20190429065607.GA55169@FreeBSD.org> <CAOshKtfcEZ7AuwkfPs56yC9oMUmmL%2Bu7JcQO3mv_5WV2fip%2BEQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--eijmnj6cbhh6zctf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, To be honest, it would probably be less of a mess if it was using a file in FILESDIR and SUB_FILES. On Wed, May 01, 2019 at 11:01:42AM +0200, Tobias C. Berner wrote: > Moin moin >=20 >=20 > I don't really see how this escaping-hell is any nicer than using -0 :) . > Generating it via shell-script on the other-hand would also have the > benefit of freebsd-version > not being called when running "make index" and such... >=20 > Let's wait and see if we need more of the possible variables, and then > rework it in the next iteration. >=20 > mfg Tobias >=20 > On Mon, 29 Apr 2019 at 08:56, Alexey Dokuchaev <danfe@freebsd.org> wrote: >=20 > > On Sun, Apr 28, 2019 at 07:22:21PM +0000, Tobias C. Berner wrote: > > > New Revision: 500363 > > > URL: https://svnweb.freebsd.org/changeset/ports/500363 > > > > > > Log: > > > New port: sysutils/etc_os-release > > > > Perhaps `misc' would've been a better category, since it's not strictly > > an utility. Missed this in the review, sorry. > > > > > +CONTENTS=3D 'NAME=3DFreeBSD\0'$\ > > > + 'VERSION=3D${VERSION}\0'$\ > > > + 'ID=3D${VERSION_ID}\0'$\ > > > + 'VERSION_ID=3Dfreebsd\0'$\ > > > + 'ANSI_COLIR=3D"0;31"\0'$\ > > > + 'PRETTY_NAME=3D"FreeBSD ${VERSION}"\0'$\ > > > + 'CPE_NAME=3Dcpe:/o:freebsd:freebsd:${VERSION_ID}\0'$\ > > > + 'HOME_URL=3Dhttps://freebsd.org/\0'$\ > > > + 'BUG_REPORT_URL=3Dhttps://bugs.freebsd.org' > > > > Oh, this is so ugly. Please consider something like this: > > > > CONTENTS=3D "NAME=3DFreeBSD" \ > > "VERSION=3D${VERSION}" \ > > "VERSION_ID=3D${VERSION_ID}" \ > > "ID=3D${OPSYS:tl}" \ > > "ANSI_COLOR=3D\\\"0;31\\\"" \ > > "PRETTY_NAME=3D\\\"${OPSYS}\ ${VERSION}\\\"" \ > > "CPE_NAME=3Dcpe:/o:freebsd:freebsd:${VERSION_ID}" \ > > "HOME_URL=3Dhttps://freebsd.org/" \ > > "BUG_REPORT_URL=3Dhttps://bugs.freebsd.org" > > > > Then you don't need -0 for xargs(1) and there's no extra newline at EOF. > > > > ./danfe > > --=20 Mathieu Arnold --eijmnj6cbhh6zctf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlzJd7dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhAaxAAnvCbwAH+BPuY/V1ytbMDYsDeD7Mmi4GmJDmrqRPo1q+6YXkNi83Tk/N9 jfS0VZKUkkWlerGSgY94XepmzSXE5qJ1zAAF0OgiGKIWVsGI6sAWq1+hLxg0gT2f zItyzY70zAlpKYfM7JnRddx8EEVFlGNOUCAZK4pXAAo+WUnN+izLWwIZv6jZdiF9 rOrazeKg+yAHQNKMRQKOcXFnkYydjupJ5CHqNn+/g3APeBi9WOLt2CdTYahdA5CH 8vMJ4NS4rhw3qAoe9gGYZ0siqWh9wzO0fwaQsbZcciaz/BeqNR8BUpOpiG+f225U QuwmhdPZj6H7DEJtIXzDeEZkU47z9JOLTX+HFeRd0kyIImk6rHuyu5BCHBP93/7q xZYI1O0EQS4cwYadCQ4FAzrODifJnTVVniJAP0ilIQqErd9jqF177VMOWztg+w/w WvubY6hiU9r9a2qoGYpm/U1gqsN7JWi9TLNtQ56F+qSWGvF4w+mFn1UXoQVoDI0L 89/QnNXIwkNLnCmyKfJMc5FAN1ffIhr0ehY7nuCDgL1ARJ0lUpIiWRhSRXb+198r lxp7+LTPlBswCly8FNkA3SXEBW3WnsS7Qy+NWUZmLU6xBCS1K85qFwegelySJlTb 21BSNnyeD61WAqIlDy8TGg/xJ036lXUV2V9HifPiRVM5yfZgWfE= =tR7e -----END PGP SIGNATURE----- --eijmnj6cbhh6zctf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190501104056.zguyzu4syrv4ms4r>