Date: Tue, 16 Mar 2021 22:17:15 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Juraj Lutter <otis@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r568508 - head/devel/node-gyp Message-ID: <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc> In-Reply-To: <202103152102.12FL2tRP068067@repo.freebsd.org> References: <202103152102.12FL2tRP068067@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--t53dsuepipbufmaa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote: > Author: otis > Date: Mon Mar 15 21:02:55 2021 > New Revision: 568508 > URL: https://svnweb.freebsd.org/changeset/ports/568508 >=20 > Log: > Add port: devel/node-gyp: a build frmework for building Node.js applica= tions. A few problems with this, and the next 2 ports added, so putting my portmgr's hat on. We do not add node modules to the ports tree. We really do not add node modules to the ports tree. If an application needs nodes modules to work, then the port for that application needs to handle the modules installing, and put those in a private place. lib/node_modules is a really aweful place to put this. As a side note, if we were to add node modules to the ports tree, which we are not, it would probably be libdata/node_modules or share/node_modules. Please remove those ports. > Reviewed by: osa (mentor) > Approved by: osa (mentor) > Differential Revision: https://reviews.freebsd.org/D29263 >=20 > Added: > head/devel/node-gyp/ > head/devel/node-gyp/Makefile (contents, props changed) > head/devel/node-gyp/distinfo (contents, props changed) > head/devel/node-gyp/pkg-descr (contents, props changed) > head/devel/node-gyp/pkg-plist (contents, props changed) >=20 > Added: head/devel/node-gyp/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/node-gyp/Makefile Mon Mar 15 21:02:55 2021 (r568508) > @@ -0,0 +1,31 @@ > +# $FreeBSD$ > + > +PORTNAME=3D gyp > +DISTVERSIONPREFIX=3D v > +DISTVERSION=3D 7.1.2 > +CATEGORIES=3D devel > +PKGNAMEPREFIX=3D node- > + > +MAINTAINER=3D otis@FreeBSD.org > +COMMENT=3D Cross-platform command-line tool written in Node.js > + > +LICENSE=3D MIT > + > +BUILD_DEPENDS=3D ${LOCALBASE}/bin/npm:www/npm > + > +USE_GITHUB=3D yes > +GH_ACCOUNT=3D nodejs > +GH_PROJECT=3D node-gyp > + > +NO_ARCH=3D yes > +NO_BUILD=3D yes > + > +do-install: > + ${MKDIR} ${STAGEDIR}${PREFIX}/lib/node_modules/node-gyp > + (cd ${WRKSRC} && \ > + ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/lib/node_modules/node-gyp \ > + "! ( -name \.* -or -path *\/\.github\/* -or -name test -or -path *\/tes= t\/* )") > + ${RLN} ${STAGEDIR}${PREFIX}/lib/node_modules/node-gyp/bin/node-gyp.js \ > + ${STAGEDIR}${PREFIX}/bin/node-gyp > + > +.include <bsd.port.mk> >=20 > Added: head/devel/node-gyp/distinfo > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/node-gyp/distinfo Mon Mar 15 21:02:55 2021 (r568508) > @@ -0,0 +1,3 @@ > +TIMESTAMP =3D 1615743601 > +SHA256 (nodejs-node-gyp-v7.1.2_GH0.tar.gz) =3D e9a42f7afa3e5386c1dee094b= 8751f6924e75d6921166d1cad6ebafc19c54957 > +SIZE (nodejs-node-gyp-v7.1.2_GH0.tar.gz) =3D 439880 >=20 > Added: head/devel/node-gyp/pkg-descr > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/node-gyp/pkg-descr Mon Mar 15 21:02:55 2021 (r568508) > @@ -0,0 +1,6 @@ > +node-gyp is a cross-platform command-line tool written in Node.js for > +compiling native addon modules for Node.js. It contains a vendored copy > +of the gyp-next project that was previously used by the Chromium team, > +extended to support the development of Node.js native addons. > + > +WWW: https://github.com/nodejs/node-gyp >=20 > Added: head/devel/node-gyp/pkg-plist > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/node-gyp/pkg-plist Mon Mar 15 21:02:55 2021 (r568508) > @@ -0,0 +1,95 @@ > +bin/node-gyp > +lib/node_modules/node-gyp/CHANGELOG.md > +lib/node_modules/node-gyp/CONTRIBUTING.md > +lib/node_modules/node-gyp/LICENSE > +lib/node_modules/node-gyp/README.md > +lib/node_modules/node-gyp/addon.gypi > +@(,,755) lib/node_modules/node-gyp/bin/node-gyp.js > +lib/node_modules/node-gyp/gyp/AUTHORS > +lib/node_modules/node-gyp/gyp/CHANGELOG.md > +lib/node_modules/node-gyp/gyp/CODE_OF_CONDUCT.md > +lib/node_modules/node-gyp/gyp/CONTRIBUTING.md > +lib/node_modules/node-gyp/gyp/LICENSE > +lib/node_modules/node-gyp/gyp/README.md > +lib/node_modules/node-gyp/gyp/data/win/large-pdb-shim.cc > +lib/node_modules/node-gyp/gyp/gyp > +lib/node_modules/node-gyp/gyp/gyp.bat > +lib/node_modules/node-gyp/gyp/gyp_main.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSNew.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSProject.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSSettings.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSSettings_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSToolFile.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSUserFile.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSUtil.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/MSVSVersion.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/__init__.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/common.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/common_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/easy_xml.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/easy_xml_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/flock_tool.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/__init__.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/analyzer.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/android.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/cmake.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/compile_commands_json.= py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/dump_dependency_json.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/eclipse.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/gypd.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/gypsh.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/make.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/ninja.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/ninja_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/xcode.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/generator/xcode_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/input.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/input_test.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/mac_tool.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/msvs_emulation.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/ninja_syntax.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/simple_copy.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/win_tool.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/xcode_ninja.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/xcodeproj_file.py > +lib/node_modules/node-gyp/gyp/pylib/gyp/xml_fix.py > +lib/node_modules/node-gyp/gyp/requirements_dev.txt > +lib/node_modules/node-gyp/gyp/setup.py > +lib/node_modules/node-gyp/gyp/test_gyp.py > +lib/node_modules/node-gyp/gyp/tools/README > +lib/node_modules/node-gyp/gyp/tools/Xcode/README > +lib/node_modules/node-gyp/gyp/tools/Xcode/Specifications/gyp.pbfilespec > +lib/node_modules/node-gyp/gyp/tools/Xcode/Specifications/gyp.xclangspec > +lib/node_modules/node-gyp/gyp/tools/emacs/README > +lib/node_modules/node-gyp/gyp/tools/emacs/gyp-tests.el > +lib/node_modules/node-gyp/gyp/tools/emacs/gyp.el > +lib/node_modules/node-gyp/gyp/tools/emacs/run-unit-tests.sh > +lib/node_modules/node-gyp/gyp/tools/emacs/testdata/media.gyp > +lib/node_modules/node-gyp/gyp/tools/emacs/testdata/media.gyp.fontified > +lib/node_modules/node-gyp/gyp/tools/graphviz.py > +lib/node_modules/node-gyp/gyp/tools/pretty_gyp.py > +lib/node_modules/node-gyp/gyp/tools/pretty_sln.py > +lib/node_modules/node-gyp/gyp/tools/pretty_vcproj.py > +lib/node_modules/node-gyp/lib/Find-VisualStudio.cs > +lib/node_modules/node-gyp/lib/build.js > +lib/node_modules/node-gyp/lib/clean.js > +lib/node_modules/node-gyp/lib/configure.js > +lib/node_modules/node-gyp/lib/find-node-directory.js > +lib/node_modules/node-gyp/lib/find-python.js > +lib/node_modules/node-gyp/lib/find-visualstudio.js > +lib/node_modules/node-gyp/lib/install.js > +lib/node_modules/node-gyp/lib/list.js > +lib/node_modules/node-gyp/lib/node-gyp.js > +lib/node_modules/node-gyp/lib/process-release.js > +lib/node_modules/node-gyp/lib/proxy.js > +lib/node_modules/node-gyp/lib/rebuild.js > +lib/node_modules/node-gyp/lib/remove.js > +lib/node_modules/node-gyp/lib/util.js > +lib/node_modules/node-gyp/macOS_Catalina.md > +lib/node_modules/node-gyp/macOS_Catalina_acid_test.sh > +lib/node_modules/node-gyp/package.json > +lib/node_modules/node-gyp/src/win_delay_load_hook.cc > +lib/node_modules/node-gyp/update-gyp.py >=20 --=20 Mathieu Arnold --t53dsuepipbufmaa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmBRIFdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgL/Ug//abxGEMSs/voHw2LAmRkLjmdkqlDi/369pqptHTstbfkljNxmyoclUCIr 2+KYotBpaYTtPLdU38EBebxJDIn7lJOiAswdfNE11FhcMDtXJftshGyJ4ckzNWbK 5jcTB50JP5V3Fhx8nWqtUhogPscYVuAkzhf17o78x1+V7lEQnWkvogbUmitOKAME fNm/z8OOhgK4px2s3hZdFTbxaHGJhzgmhLtcimVz7OHLcXxWof7fy63mpLOzcqNP AIFnVoCrKg7nMiH0mf+h0VZIebKxLQX9IJgukixk+k41LgdtcPbrlZpfk+3zUxWe kpmlwXL13MHJRzq+bX/SDtwM7O/mnGR6fMpEqIb5AHg1r9FEpoDNF7Pw3TJGc4Ry P+SDIV14Ua7RtJ3hNFyyEVLfHaufI1LxR/Zn7j7kzpRLxUJhwPd8kFvv59PyMHWo L7MfmLSSjA/kucj9QYz3LRgd6SG4Qz4ir1202AT/wYkzt3pTt9MZuHgdhvwjijYx 6MNGl/BdrRuy45dTlzzkyX5XXE60Vb6MhcwYYq4+MOmqOAYYZ0eCPMmjq/SQIg0/ fIXn6vA25n7A2TT7YNP5/ryVhE0JbJgQVnfApKT6dl8zFG1EnX6HYdGT1iQhsgJQ IEswtTr9kH3Zev/inibs3bNzDJoIPA8ilHpI3WaxQayLr5nREko= =Qb+B -----END PGP SIGNATURE----- --t53dsuepipbufmaa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210316211715.pa4w3lrffzxr3ftx>