Date: Sat, 26 Aug 2017 01:37:52 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306512 - in head/sys: kern sys Message-ID: <20170825223752.GN1700@kib.kiev.ua> In-Reply-To: <c9233211-318b-802b-27e6-862808f9ea77@FreeBSD.org> References: <201609301727.u8UHRIgD051373@repo.freebsd.org> <6ea06065-ea5c-b83b-3854-224626be0d77@FreeBSD.org> <20170825103534.GK1700@kib.kiev.ua> <c9233211-318b-802b-27e6-862808f9ea77@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 25, 2017 at 02:29:28PM -0700, Bryan Drewery wrote: > https://people.freebsd.org/~bdrewery/patches/vdrop-global-list.diff I do not object against his handling. There is really very small amount of code shared between mp != NULL and mp == NULL cases, you may consider making them use separate paths instead of adding more than one check for mp != NULL. VNASSERT() statement has wrong indent on the continuation line.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170825223752.GN1700>