Date: Sat, 2 Feb 2008 08:18:56 +0100 From: Hans Petter Selasky <hselasky@freebsd.org> To: Alfred Perlstein <alfred@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 129920 for review Message-ID: <200802020818.57037.hselasky@freebsd.org> In-Reply-To: <20080202022234.GR99258@elvis.mu.org> References: <200712020001.lB201XbN000811@repoman.freebsd.org> <20080202022234.GR99258@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 02 February 2008, Alfred Perlstein wrote: > This change makes very little sense. If xfer->frbuffers is a bare > pointer, then why add 0 to it? Just pass xfer->frbuffers or use a > macro that explains what you are doing. > I can change those to a plain "xfer->frlengths". It was just a reminder for me, because some places we use "xfer->frlengths + 1" and "xfer->frbuffers + 1". I will write a script that converts all of those. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802020818.57037.hselasky>