Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 29 Jun 2016 19:32:10 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-arm@FreeBSD.org
Subject:   [Bug 210705] freebsd/sys/arm/mv/mv_common.c:2252]: (style) Suspicious condition
Message-ID:  <bug-210705-7@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210705

            Bug ID: 210705
           Summary: freebsd/sys/arm/mv/mv_common.c:2252]: (style)
                    Suspicious condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: arm
          Assignee: freebsd-arm@FreeBSD.org
          Reporter: dcb314@hotmail.com

freebsd/sys/arm/mv/mv_common.c:2252]: (style) Suspicious condition (assignm=
ent
+ comparison); Clarify expression with parentheses.

Source code is

        if (fdt_addrsize_cells(node, &addr_cells, &size_cells) =3D=3D 0 &&
            (par_addr_cells =3D fdt_parent_addr_cells(node) <=3D 2)) {

Maybe better code

        if (fdt_addrsize_cells(node, &addr_cells, &size_cells) =3D=3D 0 &&
            (par_addr_cells =3D fdt_parent_addr_cells(node)) <=3D 2) {

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210705-7>