Date: Tue, 07 Oct 2014 16:59:36 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r370242 - in head/emulators: . hyperv-is hyperv-is/files Message-ID: <55F3F598E11FE4EBDB3743DB@ogg.in.absolight.net> In-Reply-To: <5433F63B.8000506@marino.st> References: <201410062258.s96MwoqK063529@svn.freebsd.org> <A1AB28657D5EF303B9BEE5D2@ogg.in.absolight.net> <5433E4F7.9030903@marino.st> <BEA6C4E87B469EEE5D8476C1@ogg.in.absolight.net> <5433F63B.8000506@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 7 octobre 2014 16:18:35 +0200 John Marino <freebsd.contact@marino.st> wrote: | On 10/7/2014 16:14, Mathieu Arnold wrote: |> |> |> +--On 7 octobre 2014 15:04:55 +0200 John Marino |> <freebsd.contact@marino.st> wrote: |> | On 10/7/2014 11:59, Mathieu Arnold wrote: |> |> +--On 6 octobre 2014 22:58:50 +0000 John Marino <marino@FreeBSD.org> |> |> wrote: |> |> | +@cwd /boot/kernel |> |> | +%%A%%hv_ata_pci_disengage.ko |> |> | +%%A%%hv_netvsc.ko |> |> |> |> Please, do not use @cwd, it is confusing, and not needed since pkg_* |> |> has gotten out. List files with their path like this : |> |> %%A%%/boot/kernel/hv_ata_pci_disengage.ko |> | |> | In my defense: |> | 1) It works (tested pretty thoroughly) |> | 2) The alternative to @cwd is not documented in UPDATING so I had no |> | idea what the alternative was. |> | 3) cwd is documented here with no alternative: |> | https://www.freebsd.org/doc/en/books/porters-handbook/plist-keywords.h |> | tml |> | |> | So it's not really fair to bang on us for stuff that is undocumented. |> | right? This theme is getting repetitive too. |> |> Well, it's a bit the other way around, @cwd was the alternative to |> listing the full path to the filenames, so, I could document the |> alternative to the alternative, but it feels a bit silly :-) | | It was my understanding that pkg-plist lists assigned a ${PREFIX} prefix | and @cwd was the only way to list files outside of the prefix. This is | why I was surprised that stuff like /var/db/mydir worked. I don't know | when absolute paths got supported. Absolute path always were supported with pkg, so people have been using those for some time. | for me, absolute path is something new, not a baseline. | Why would @cwd even exist if it wasn't necessary in the past? Well, nothing in the handbook tells you to use @cwd, the only occurrence of it is in its own documentation section, and make makeplist will output a clean plist, without using @cwd. Regards, -- Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55F3F598E11FE4EBDB3743DB>