Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 04 Oct 1995 04:27:43 -0700
From:      David Greenman <davidg@Root.COM>
To:        Peter Wemm <peter@jhome.dialix.com>
Cc:        Julian Elischer <julian@freefall.freebsd.org>, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Subject:   Re: cvs commit: src/sys/i386/linux linux_misc.c 
Message-ID:  <199510041127.EAA00513@corbin.Root.COM>
In-Reply-To: Your message of "Wed, 04 Oct 95 18:16:04 %2B0800." <Pine.BSF.3.91.951004180907.1120G-100000@jhome.DIALix.COM> 

next in thread | previous in thread | raw e-mail | index | archive | help
>On Wed, 4 Oct 1995, Julian Elischer wrote:
>> julian      95/10/04 00:08:05
>> 
>>   Modified:    sys/i386/i386  trap.c
>>                sys/i386/linux  linux_misc.c
>>   Log:
>>   Submitted by:	Juergen Lock <nox@jelal.hb.north.de>
>>   Obtained from: other people on the net ?
>>   
>>   1. stepping over syscalls (gdb ni) sends you to DDB, and returned
>>   to the wrong address afterwards, with or without DDB.  patch in
>>   i386/i386/trap.c below.
>>   
>>   2. the linux emulator (modload'ed) still causes panics with DIAGNOSTIC,
>>   re-applied a patch posted to one of the lists...
>
>BTW: #2 looks exactly like my patch that I posted some months ago on the 
>lists..
>
>If I remember rightly, Terry complained about the changes that I made, 
>saying that it's bad news having a dozen or so "return"s in the function 
>all trying to keep track of the changing locking state, and I agree with 
>him.  I rewrote it after cleaning it up, but never got a chance to do 
>anything with it, as jhome lost it's filesystem...

   If you had changed it to contain too many goto's, I would have complained,
too, especially since I'm the author of most of the current trap() function.
:-)

-DG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199510041127.EAA00513>