Date: Mon, 01 Apr 2002 14:45:35 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Julian Elischer <julian@elischer.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 8807 for review Message-ID: <XFMail.20020401144535.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0204011115520.15571-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01-Apr-2002 Julian Elischer wrote: > I ansify every declaration I come across.... Well, to be honest, those should be done separate from code commits. :) Also, most of this file still uses K&R. I probably should do a sweep of the file prior to committing to fixup all the declarations, but doing so would probably trigger some flamewar or another over it. :) > On Mon, 1 Apr 2002, John Baldwin wrote: > >> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8807 >> >> Change 8807 by jhb@jhb_laptop on 2002/04/01 11:11:59 >> >> Bah, K&R function declarations suck. :) I missed removing the flag >> argument the second time. Bite the bullet and just use ANSI >> declarations for suser() and suser_cred(). >> >> Affected files ... >> >> ... //depot/projects/smpng/sys/kern/kern_prot.c#53 edit >> >> Differences ... >> >> ==== //depot/projects/smpng/sys/kern/kern_prot.c#53 (text+ko) ==== >> >> @@ -1265,9 +1265,7 @@ >> * specify jail interaction. >> */ >> int >> -suser_cred(cred, flag) >> - struct ucred *cred; >> - int flag; >> +suser_cred(struct ucred *cred, int flag) >> { >> >> if (!suser_enabled) >> @@ -1284,9 +1282,7 @@ >> * caller, promoting binary compatibility. >> */ >> int >> -suser(td) >> - struct thread *td; >> - int flag; >> +suser(struct thread *td) >> { >> >> return (suser_cred(td->td_ucred, 0)); >> > -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020401144535.jhb>