Date: Sat, 4 Nov 2017 16:55:03 +0100 From: Mariusz Zaborski <oshogbo@FreeBSD.org> To: "Herbert J. Skuhra" <herbert@mailbox.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_g... Message-ID: <20171104155503.GA10168@x-wing> In-Reply-To: <87h8uexoix.wl-herbert@mailbox.org> References: <201710281923.v9SJNvE5021346@repo.freebsd.org> <87h8uexoix.wl-herbert@mailbox.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 01, 2017 at 11:48:54AM +0100, Herbert J. Skuhra wrote: > On Sat, 28 Oct 2017 21:23:57 +0200, > Mariusz Zaborski <oshogbo@FreeBSD.org> wrote: > >=20 > > Author: oshogbo > > Date: Sat Oct 28 19:23:57 2017 > > New Revision: 325062 > > URL: https://svnweb.freebsd.org/changeset/base/325062 > >=20 > > Log: > > Introduce caspermocks. > > =20 > > The idea behinds mocks is that we don't need to ifdef a lot of code in > > tools itself but those defines are hidden in the casper library. > > Right now the mocks are implemented as define/inlines functions. > > There was a very long discussion how this should be implemented. > > This approach has some advantages like we don't need to link to any a= dditional > > libraries. Unfortunately there are also some disadvantages for exampl= e it is > > easy to get library out of sync between two versions of functions or = that we > > need extra define to compile program with casper support. > > This isn't an ideal solution but it's good enough for now and should = simplify > > capsicumizing programs. This also doesn't close us any other ways to = do those > > mocks and this should evolve in time. > > =20 > > Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery > > Differential Revision: https://reviews.freebsd.org/D8753 >=20 > Again, after this commit libcasper.so.0 is installed to /usr/lib and not > /lib: >=20 > % ls -l /usr/lib/libcasper.so* > lrwxr-xr-x 1 root wheel 14 Oct 29 10:51 /usr/lib/libcasper.so -> li= bcasper.so.0 > -r--r--r-- 1 root wheel 22424 Oct 29 10:51 /usr/lib/libcasper.so.0 >=20 > But usr/lib/libcasper.so.0 is listed in ObsoleteFiles.inc: >=20 > % grep -B 2 libcasper.so /usr/src/ObsoleteFiles.inc > # 20131202: libcapsicum and libcasper moved to /lib/ > OLD_LIBS+=3Dusr/lib/libcapsicum.so.0 > OLD_LIBS+=3Dusr/lib/libcasper.so.0 Thank you for reporting. Should be fixed in the r325399. Thanks, --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD commiter | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAln94tQACgkQ38KEGuLG xWSs/A//ZGbrkmrU587d+dUAK+EhSou3RHj/hjzK3VFnzuc5nwvRPeAqC+ghFjeR 85t5anB5LvLxyq33Utw9xiL4ymYtH3QjYK3Dw7DNXlr1ZO7cyqGqsS9lTB/abqby 4qFQZCZBrOdipFzeCg480azyn+vit7Wcbxj7pZgItIeaeUK0ipXWe02Q9pd0IrVy iQKNqWePiJcdDvmr9NUMY6Q+mvUGdzPXI5ooas+CiKAhU4RaJbrBbK+Wml9wv0mG gdrzTpGF6RPbtq6JH8hxqNU75NmpJkZSCVvzK5/UA9j9P7SfkF3PLuWGvVZFXNB0 vUrjFN7Ap0LEeG8GObsraXdXQRi1vKdSEulc5Su6csQI3zzAF5LvTLmu0qhkDG6C SopLn6JUOjkoh2fOK6MucMb3UuR4N28L2PZUunu8HdjHbFlxSrEAWcLhSq3NOTqK WUMroPedd6WjyeUJHn+AYwpeWBLl28fFlVomShR4eFEsOaX7LLyo1EuRf+ZMaJxg 6D655bxOIMbPP9BslLlr/1F4ayjCI37+cvOy/zVySqVkauKxCg2lIFi8L/17G3lA AAZ4aFp2Wd2jOz+ws4XEPfjIuFxhJc+26Z4Cw9MdDdMlc6JQ/0R8MJMfhMlE23hM IAuWU31Upkq2Zk1uDSLe7QiKeyDs7VF7TV/06r0bTWMR2nbCp1E= =mWfb -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171104155503.GA10168>