Date: Sat, 01 Sep 2001 16:02:38 -0700 From: Julian Elischer <julian@elischer.org> To: Matt Dillon <dillon@earth.backplane.com> Cc: Peter Wemm <peter@wemm.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c Message-ID: <3B91690E.662A1CCB@elischer.org> References: <20010901221226.48CC33807@overcee.netplex.com.au> <200109012243.f81MhJ976806@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matt Dillon wrote: > > :Yes, John's stuff could be done in the main tree. But he's using p4 as a > :tool where he commits frequent tweaks to the tree, and uses that for > :syncing his test boxes for testing after commits. As soon as there's > :enough to commit that has been tested properly he commits it to cvs. If > :you'd prefer that he commit untested stuff to cvs and then test after the > :fact, then please say the word. BTW: KSE is MFC'd up to present time on P4.. > : > :Cheers, > :-Peter > :-- > :Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > > It depends what you define as testing. 95% of the code modifications > related to the proc lock and the struct file and struct filedesc locking > do not require a great deal of testing because they don't actually do > anything. These all devolve into defining a few procedures (guys, please > stop using macros!) which can initially be left empty or do nothing more > then minimal ref counting to make sure things match up. 95% of the > work is inserting the locking and unlocking procedure calls wherever they > are needed throughout the codebase - but since the procs don't really > do anything, this can all be done in the main tree and all be done with > only minimal testing. > > It's the last 5% that requires the serious testing -- making the locking > and unlocking procedures actually do something real. After that it simply > becomes a matter of removing or pushing-down the Giant wrapper in the > now-protected routines, one syscall at a time or one file at a time, > with moderate testing. It's that simple. > > -Matt -- +------------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / hard at work in | / \ julian@elischer.org +------>x USA \ a very strange | ( OZ ) \___ ___ | country ! +- X_.---._/ presently in San Francisco \_/ \\ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B91690E.662A1CCB>