Date: Thu, 11 Jul 2013 10:03:05 -0300 From: William Grzybowski <william88@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, William Grzybowski <wg@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent Message-ID: <CAHtVNLMJ7CzNC6X%2BeO6g8=qp9zvCoEwM9iXMPRm9-WTS75TYPQ@mail.gmail.com> In-Reply-To: <20130711125532.GA72196@FreeBSD.org> References: <201307101754.r6AHshZl027414@svn.freebsd.org> <20130711054533.GA70334@FreeBSD.org> <CAHtVNLPCmTBpC2uvaYdR2%2B1qQpCgr2UqUmgycF9Qdg4oBgNMVA@mail.gmail.com> <20130711125532.GA72196@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 11, 2013 at 9:55 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Thu, Jul 11, 2013 at 08:42:23AM -0300, William Grzybowski wrote: >> On Thu, Jul 11, 2013 at 2:45 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> > On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote: >> >> New Revision: 322724 >> >> URL: http://svnweb.freebsd.org/changeset/ports/322724 >> >> >> >> @@ -43,7 +46,7 @@ CONFIGURE_ARGS+= --disable-qt-dbus >> >> .endif >> >> >> >> post-patch: >> >> - @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp >> >> + @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp >> > >> > There are two problems with this part: >> > [...] >> >> It would make everyones life easier if you had put a comment in the >> post-patch line about that fact. > > True; usually I document any REINPLACE_CMD which might be confusing to > others, in this case I thought it's kinda self-explanatory. The point > is that 1) many porters/comitters do not document these things, and it > might happen to anyone else; 2) regardless of the presence of comment, > or lack thereof, anyone who is updating the port should recheck if any > previous patch(es) are still valid. This was obviously not done here. Point taken, twice, and I appreciate your comments, I screwed up. How long should I knee in grains of corn? ;) -- William Grzybowski ------------------------------------------ Curitiba/PR - Brasil
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHtVNLMJ7CzNC6X%2BeO6g8=qp9zvCoEwM9iXMPRm9-WTS75TYPQ>