Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jul 2002 02:51:59 -0700 (PDT)
From:      Don Lewis <dl-freebsd@catspoiler.org>
To:        hsu@FreeBSD.org
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netinet udp_usrreq.c
Message-ID:  <200207120952.g6C9pxwr013357@gw.catspoiler.org>
In-Reply-To: <0GZ400HU8PNLLG@mta7.pltn13.pbi.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12 Jul, Jeffrey Hsu wrote:
>   > Comparing udp_getcred() with tcp_getcred(), the missing lock looked like
>   > an oversight.
> 
> Okay, I see the confusion.  I had the same question when I reviewed Jennifer's
> patch, but decided to err on the side of conservatism and allow it.  I actually
> believe that lock is unnecessary in tcp_getcred().

Now that I look at it, I think TCP has the opposite problem.  I don't
see either inp or tcbinfo being locked in tcp_close() before it
calls in_pcbdetach().


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207120952.g6C9pxwr013357>