Date: Thu, 06 Apr 2017 05:54:45 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: Cy Schubert <Cy.Schubert@komquats.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316487 - head/etc Message-ID: <201704061254.v36CsjSl008801@slippy.cwsent.com> In-Reply-To: Message from =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> of "Thu, 06 Apr 2017 09:50:58 %2B0200." <868tne3rfh.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <868tne3rfh.fsf@desk.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav? = w rites: > Cy Schubert <Cy.Schubert@komquats.com> writes: > > Dag-Erling Smørgrav <des@des.no> writes: > > > Could you please revert? > > Sure, it's been reverted. > > No, you misunderstood... I meant revert *my* commit. I didn't know it > had already been fixed (for some value of fixed) when I wrote this. It's reverted now. > > > Are you thinking of a more intrusive change like my first draft of the > > patch? > > Sorry, haven't looked at your patch. Mine adds check_debug, check_force > etc. and uses them everywhere. > > Note that none of these variables are documented, so using them outside > of rc.subr itself is arguably a bug. Agreed. Regardless, an UPDATING entry will still be needed because ports and third party software may have the same "bug" as rc.d/dhclient and rc.d/bgfsck. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704061254.v36CsjSl008801>